Repository navigation
Conversation
…ctions_latest_share gh actions-lock files `owner/repo/sub/path@ref` under `owner/repo@ref`, with owner and repo in lower case. Both collectors compared the workflow's `uses:` value verbatim, so a locked sub-path action read as not pinned and as not a SHA. lockKey (lib/lock-key.mjs) writes the key the lock uses. readLock and the pinned-share check, and lockedCommits and actionPins, both go through it. Closes SoulCraft-Org#168 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: paulfoley <268432743+paulfoley@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #168
lockKey(uses)inquality/collectors/lib/lock-key.mjs:owner/repo@ref, sub-path dropped, owner and repo lower-cased. The GitHub collector (readLock,actions.pinned_share) and the Tools collector (lockedCommits,actionPins, sotools.actions_latest_share) match through itgh actions-lockfilesowner/repo/sub/path@refunderowner/repo@ref, lower-cased. Both collectors compared theuses:value verbatim, so a locked sub-path action read as not pinned (actions.pinned_share) and as not a SHA (tools.actions_latest_share)node --test quality/collectors/github/github-security.test.mjs quality/collectors/tools/tools.test.mjs quality/collectors/lib/seam.test.mjs(56 pass). Two new cases useAcme/Kit/sub/path@v1.2.3against the lock keyacme/kit@v1.2.3. WithlockKeyreturning its input, both failuses:with no sub-path and a lower-case owner keys exactly as beforeowner/repoin lower case, so a workflow that spells the ownerAcme/Kit/sub@v1still missed after the sub-path fix. GitHub names are not case-sensitive.toLowerCase()inlockKeylib/, not a copy in each collectorlib/🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.