Skip to content

Fix ci.light_run_share counting a ci-standard caller's by-design skips as light - #170

Open
paulfoley wants to merge 1 commit into
SoulCraft-Org:mainfrom
paulfoley:fix/ci-light-run-short-only
Open

paulfoley wants to merge 1 commit into
SoulCraft-Org:mainfrom
paulfoley:fix/ci-light-run-short-only

Conversation

@paulfoley

@paulfoley paulfoley commented Nov 20, 2026 •

Copy link
Copy Markdown

Closes #167

Item Detail
What changed describeRun takes the by-design skips of a ci-standard caller. New standardCalls(root) in ci-stages.mjs reads each workflow file: the caller job names, and the short or standard jobs the caller passed no commands for. The described and jobsOf loaders pass them in
Why A caller with only short: skips standard by design, and its short job skips the python and pip steps because their inputs are unset. Both read as work skipped for lack of changes, so every passing run under 60 s counted as light. The metric means "skipped because nothing changed" (quality/targets/ci.json)
How it was verified node --test quality/collectors/ci/ci-collect.test.mjs (30 pass), plus ci.test.mjs and ci-spend.test.mjs (34 pass). The new case "does not count as skipped work what a CI standard caller skips by design" uses a short-only caller and the jobs of one passing 50 s run. Without the inputs it reads light; with them it does not
How to reverse it Revert the commit; describeRun's third argument is optional, so other callers are unchanged
Judgment call Reason How to reverse it
Also ignore skipped steps inside a caller's ci-standard jobs, not only the unset job A run of a short-only caller still skips the setup-python and pip steps, and 50 s is under the 60 s cut, so fixing the job alone left the run light Drop the guarded clause in describeRun
An unset short counts the same as an unset standard The standard skips either job when its input is blank Filter the input list in standardCalls to standard
A file that does not parse reads as no call Fail open: every skip counts, as before, instead of the metric failing Remove the try in standardCalls

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

…s as light

A caller of ci-standard.yml that passes only `short:` skips the `standard`
job by design, and the short job skips its python and pip steps because
their inputs are unset. describeRun read both as work skipped for lack of
changes, so every passing run under a minute counted as light.

describeRun now takes the caller's by-design skips, read from its workflow
file by standardCalls: the caller job names and the short or standard jobs
it passed no commands for. A configured job the changes job skipped is
still light.

Closes SoulCraft-Org#167

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: paulfoley <268432743+paulfoley@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci.light_run_share counts every ci-standard run as light when a repo passes only short:

1 participant