Repository navigation
Conversation
…s as light A caller of ci-standard.yml that passes only `short:` skips the `standard` job by design, and the short job skips its python and pip steps because their inputs are unset. describeRun read both as work skipped for lack of changes, so every passing run under a minute counted as light. describeRun now takes the caller's by-design skips, read from its workflow file by standardCalls: the caller job names and the short or standard jobs it passed no commands for. A configured job the changes job skipped is still light. Closes SoulCraft-Org#167 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: paulfoley <268432743+paulfoley@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #167
describeRuntakes the by-design skips of a ci-standard caller. NewstandardCalls(root)inci-stages.mjsreads each workflow file: the caller job names, and theshortorstandardjobs the caller passed no commands for. ThedescribedandjobsOfloaders pass them inshort:skipsstandardby design, and itsshortjob skips the python and pip steps because their inputs are unset. Both read as work skipped for lack of changes, so every passing run under 60 s counted as light. The metric means "skipped because nothing changed" (quality/targets/ci.json)node --test quality/collectors/ci/ci-collect.test.mjs(30 pass), plusci.test.mjsandci-spend.test.mjs(34 pass). The new case "does not count as skipped work what a CI standard caller skips by design" uses a short-only caller and the jobs of one passing 50 s run. Without the inputs it reads light; with them it does notdescribeRun's third argument is optional, so other callers are unchangedsetup-pythonand pip steps, and 50 s is under the 60 s cut, so fixing the job alone left the run lightguardedclause indescribeRunshortcounts the same as an unsetstandardstandardCallstostandardtryinstandardCalls🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.