SONARJAVA-6850 Fix SonarQube QG

[aurelien-coet-sonarsource]

---

Summary by Gitar

• Code quality improvements:
  • Added null checks across various check implementations like UnusedLocalVariableCheck and MathOnFloatCheck
  • Replaced subtraction-based comparisons with Integer.compare to prevent overflow issues

_{This will update automatically on new commits.}

[hashicorp-vault-sonar-prod]

SONARJAVA-6850

[gitar-bot]

Code Review ✅ Approved 2 resolved / 2 findings

Adds null checks and integer comparisons across several check implementations to resolve issues with the isRValue null guard and TreeSorter comparisons.

✅ 2 resolved

✅ Bug: isRValue null guard flips result toward false-positive path

📄 java-checks/src/main/java/org/sonar/java/checks/unused/UnusedLocalVariableCheck.java:111-122 📄 java-checks/src/main/java/org/sonar/java/checks/unused/UnusedLocalVariableCheck.java:103-105
In the old code parent.parent() was only evaluated when parent.is(INCREMENT_KINDS) was true (short-circuit &&), so a non-increment parent always yielded true (identifier counted as a read). The rewrite hoists the null check out of the conjunction, so grandParent == null now returns false for any parent kind, and parent == null also returns false; because isUnused uses noneMatch(isRValue), false means "this usage is not a read", i.e. the fallback for an unknown/detached tree now pushes the check toward reporting an unused variable (and offering a quick fix that deletes the declaration) instead of staying silent. Keep the guard inside the increment branch and default the unknown cases to true.

✅ Quality: JavaQuickFix TreeSorter: only last of four comparisons migrated

📄 java-frontend/src/main/java/org/sonar/java/reporting/JavaQuickFix.java:103-109
The PR replaces the subtraction in the final return of TreeSorter.compare with Integer.compare, but the three preceding comparisons in the same method (startLine, startCharacter, endLine) still compute their ordering via subtraction, leaving the mechanical change half applied in a single method. Convert them all so the comparator is consistent (and uniformly overflow-safe).

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
10 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
80.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube