Skip to content

SONARJAVA-6820: Fix S9355: ignore Eclipse (non-Javadoc) override comments - #5984

Merged
nathsou merged 4 commits into
masterfrom
SONARJAVA-6820
Aug 21, 2026
Merged

SONARJAVA-6820: Fix S9355: ignore Eclipse (non-Javadoc) override comments#5984
nathsou merged 4 commits into
masterfrom
SONARJAVA-6820

Conversation

@nathsou

@nathsou nathsou commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Stop raising S9355 when a comment contains the Eclipse (non-Javadoc) marker.
  • The marker alone is enough; @see is not required.
  • Keep flagging a regular @see comment that is not an Eclipse stub.
  • Refresh the generated S9355 description from the RSPEC branch.

Links

AI disclosure

  • LLM model used for implementation: cursor-grok-4.6-high

@nathsou nathsou self-assigned this Aug 21, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

SONARJAVA-6820

@datadog-sonarsource

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Ruling needs updating. A fix PR has been created: #5985

Please review and merge it into your branch.

@github-actions

Copy link
Copy Markdown
Contributor

Ruling needs updating. A fix PR has been created: #5985

Please review and merge it into your branch.

@github-actions

Copy link
Copy Markdown
Contributor

Ruling needs updating. A fix PR has been created: #5985

Please review and merge it into your branch.

@gitar-bot

gitar-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Fixes S9355 false positives by ignoring Eclipse (non-Javadoc) override comments without requiring an associated @see tag. No issues found.

Implementation Status 🟡 0 / 1 issues implemented
SONARJAVA-6820 — 0 / 1 objectives

The PR does not contain any code changes related to AlmostJavadocCheck or S9355, leaving the objective unimplemented.

  • ⬜ Do not raise S9355 when a regular comment contains the Eclipse (non-Javadoc) marker
Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

Copy link
Copy Markdown
Contributor

@nathsou
nathsou merged commit 2d350a0 into master Aug 21, 2026
17 checks passed
@nathsou
nathsou deleted the SONARJAVA-6820 branch August 21, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants