syncItems filter now excludes only slot="trigger" instead of all chil… - #850
Merged
Conversation
…dren with any slot. First run assigns slots, second run keeps them — no more empty menu
…istry@3.1.2-2) (latest: rdflib@2.4.0)
SharonStrats
reviewed
Aug 3, 2026
SharonStrats
left a comment
SharonStrats
left a comment
Contributor
There was a problem hiding this comment.
I think this makes sense even if we don't need it in this specific thing (as I think we should solve this case by just rerendering the pane itself not the header) but we may run into this again in the future. I just want to test it out with the panes that are using it though to make sure it doesn't effect them. I will do it soon. I just want to finish this editing task first before changing my environment to test.
SharonStrats
approved these changes
Aug 4, 2026
SharonStrats
left a comment
SharonStrats
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I think we need this no matter what.
… into fix/solid-ui-menu
…istry@3.1.2-2) (latest: rdflib@2.4.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dren with any slot. First run assigns slots, second run keeps them — no more empty menu