fix(ci): harden core tool watch issue reconciliation - #104
Draft
lelia wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
mainpushes, while keeping pull requests in build-guard mode.core-tool-driftissue: update/reopen it when drift exists, refresh and close it when drift is resolved, and avoid resolving it when release discovery is incomplete.ghcr.io/socketdev/trivypackage produced bySocketDev/trivy-dist, withpackages: read, instead of Aqua's release feed.socket-sdk-python) and add rows for Socket Python CLI (socket-python-cli) and Socket npm CLI (socket-cli).socketCLI in every image and pinsocketsecurityinapp_tests; also watchDockerfile.heavy.publish-dockerworkflow'screate-releasejob. Image publishing now ends after manifest verification, leaving GitHub release authoring intentionally manual.Root cause
The post-release run was triggered by a push, which selected
mode=build. That mode intentionally skipped latest-version discovery, and the issue step only ran for watch-mode reports with active drift. The job therefore generated and uploaded a fresh report but never reconciled issue #93, leaving its pre-merge pins in place.Impact
After this lands, a relevant merge to
mainimmediately refreshes issue #93. If every tracked tool is current, the workflow updates the body and closes the issue; later drift reuses and reopens the same issue rather than creating duplicates. Transient feed failures are called out in the report and cannot falsely resolve drift.The Docker publish workflow no longer starts a runner for an automatic GitHub release step that is expected to no-op. Maintainers remain responsible for authoring each release and may still use GitHub's generated notes manually.
Validation
uv run --no-sync pytest -q— 222 passedactionlint .github/workflows/core-tool-watch.ymlactionlint .github/workflows/publish-docker.ymlzizmor .github/workflows/publish-docker.yml— no findingsgit diff --checkdiscovery_complete=true