Skip to content

feat: preserve approval_ids in final edge output - #98

Merged
SkyeAv merged 2 commits into
mainfrom
allow-approved-ids
Aug 14, 2026
Merged

feat: preserve approval_ids in final edge output#98
SkyeAv merged 2 commits into
mainfrom
allow-approved-ids

Conversation

@SkyeAv

@SkyeAv SkyeAv commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Allows DAKP’s FDA application-number annotations to survive in Tablassert’s final KGX output as structured edge fields.

Final edge output

  • Allow-list wiring: Adds approval_ids to TABLASERT_EDGE_EXTRAS, preventing folding into supporting_text.
  • DAKP-compatible scalar: Preserves pipe-joined values such as 011111|022222 verbatim as scalar strings.

Validation and docs

  • Pending handling: Updates class pruning, KGX pending validation, and agent scoring guidance.
  • Documentation: Updates docs/configuration/table.md, docs/agent.md, docs/cli.md, and CHANGELOG.md.

Testing

  • uv run pytest ... -k 'approval or fold_unknown or prune_to_class or allowed_edge_fields or pending or annotation_warns' -q24 passed
  • uv run pytest tests/test_docs_cli_coverage.py tests/test_agent_docs.py -q11 passed
  • uv run ruff check src tests → passed
  • uv run ruff format --check src tests → passed
  • uv run pyright ...0 errors
  • Full suite → 890 passed, 35 skipped, 1 failed, 1 error; remaining failures require missing optional [qc] dependencies.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4d61583e-e20e-43d7-99a1-07f3f6bb1bc1


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SkyeAv
SkyeAv merged commit 4697796 into main Aug 14, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant