Skip to content

fix: disable species context qualifier output - #96

Merged
SkyeAv merged 2 commits into
mainfrom
fix/disable-species-context-qualifier
Aug 14, 2026
Merged

fix: disable species context qualifier output#96
SkyeAv merged 2 commits into
mainfrom
fix/disable-species-context-qualifier

Conversation

@SkyeAv

@SkyeAv SkyeAv commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Prevents species_context_qualifier from being inferred from resolved node taxon metadata and leaking into supporting-study text or final edge output. Node taxon metadata remains available on resolved nodes.

Disabled Field Policy

  • Stable policy: Adds DISABLED_EDGE_FIELDS in src/tablassert/biolink.py and excludes disabled fields from ALLOWED_EDGE_FIELDS.
  • Pipeline filtering: Removes derivation and filters the field in src/tablassert/lib.py before class pruning, study serialization, or supporting-text folding.
  • Configuration validation: Rejects the field through both qualifier and annotation entry points with field-disabled.

Documentation

  • Updates docs/configuration/table.md, src/tablassert/agent.py, and CHANGELOG.md.
  • Adds regression coverage for configuration rejection and generated output.

Fixes

  • Incorrect inference: The previous behavior used default resolved taxon metadata to synthesize an edge qualifier. Unsupported edge handling then relocated it into supporting-study descriptions.
  • Accepted caveat: Existing configurations that author this field now fail validation intentionally. Existing generated artifacts must be regenerated.

Testing

  • uv run pytest -q896 passed, 35 skipped
  • uv run ruff check . → all checks passed
  • uv run ruff format --check . → 74 files already formatted
  • uv run pyright → 0 errors, 0 warnings, 0 informations
  • cargo fmt --check --manifest-path rust/Cargo.toml → passed
  • cargo test --manifest-path rust/Cargo.toml → 69 unit tests and 10 integration tests passed; 1 ignored
  • cargo clippy --manifest-path rust/Cargo.toml --all-targets -- -D warnings → passed

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b4966462-694d-4d32-8abd-390c7bad1c99


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…ontext-qualifier

# Conflicts:
#	CHANGELOG.md
@SkyeAv
SkyeAv merged commit 613edcd into main Aug 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant