Repository navigation
ci: run the oracle check on factory/ PRs only - #152
Merged
Merged
Conversation
The release PR (dev → master, #150) failed it: across the release range, #91's commits legitimately updated tests in #90's and #107's oracles, and the check counts every later commit. The factory README already scopes it to a factory/ PR, where an oracle is frozen for its own issue's build; each feature PR into dev still runs it there.
ShuhaoZQGG
marked this pull request as ready for review
November 14, 2026 21:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # (no issue; fixes CI on the release PR #150)
Why
CI on #150 (dev → master) fails at "Oracle tests untouched since the oracle commit" (run 43643505307). Across the release range, #91's commits (5de8185, 568a64d) legitimately updated tests listed in #90's and #107's oracles. The check counts every later commit since the base, so a release PR trips it. It was already failing on 330a495, before #151.
What changes
.github/workflows/ci.yml: the oracle step runs only when the PR head starts withfactory/(if: startsWith(github.head_ref, 'factory/')). That's what.factory/README.mdalready says: "fails afactory/PR". Factory PRs into dev still get the check. Push runs are unaffected in practice, since they compared dev with itself and found nothing.Security
None.
Production impact
None. CI only.
Testing
node scripts/factory/check-oracle.mjs --base origin/masteron dev reproduces the failure (Simple Format import: words in the speaker name override the role in parentheses #90, Timer reach metric: attach audience_size to timer_started events #107).--base origin/devpasses.if.npm test,test:e2eandtest:specsare unaffected (no code change).Evidence (real Zoom client)
Not applicable: no app change.
Not verified
The fix takes effect on #150 once this is merged into dev, since #150's head is dev.
Look here first
.github/workflows/ci.yml: the oracle step.