Repository navigation
chore(zoom-testing): quit Zoom at the end of a run - #148
Merged
Merged
Conversation
A run now ends with zoom-down.sh: end the test meeting and quit the client, then say in chat that the Mac is free. With Zoom left open the user could not tell whether the run was over. Not done when the run paused because the user took the Mac.
ShuhaoZQGG
marked this pull request as ready for review
November 14, 2026 21:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # (no issue; requested directly)
Why
After a Zoom-client test run, Zoom stayed open, so the user couldn't tell whether the run was over and whether they could use the Mac again.
What changes
.claude/skills/zoom-app-testing/scripts/zoom-down.sh: the last teardown step. It asks Zoom to quit, falls back to SIGTERM and then SIGKILL, which ends the test meeting, and writes a line to the activerun.md.zoom-app-testingskill:CLAUDE.md(next to the "taking the Mac" notice) and thefactory-zoomstation (step 6): the same rule.Security
None.
Production impact
None. This is test tooling only.
Testing
npm test/npm run test:e2e: not affected (no app code).npm run test:specs: 8 specs valid (pre-push).zoom-down.shran on the test Mac (Zoom 7.2.5) three ways:Evidence (real Zoom client)
The script runs on the real client (above). No spec covers skill scripts.
Not verified
Quitting from inside a live meeting with the "End meeting for all?" sheet showing. The SIGTERM fallback covers that case, but I haven't seen it happen.
Look here first
.claude/skills/zoom-app-testing/scripts/zoom-down.sh