fix: use portable grep -oE for Java version detection on macOS - #28
Open
WeToolX wants to merge 1 commit into
Open
fix: use portable grep -oE for Java version detection on macOS#28WeToolX wants to merge 1 commit into
WeToolX wants to merge 1 commit into
Conversation
BSD grep on macOS does not support the GNU-only -P flag, causing check-deps.sh to fail with 'invalid option -- P' for OpenJDK versions that report a plain major version such as 25. Use grep -oE '[0-9]+' instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27.
Problem
check-deps.shfails on macOS because it uses the GNU-onlygrep -oPflag, which is not supported by BSDgrep:This fallback runs when the primary
sedextraction returns empty, which happens for OpenJDK versions that report a plain major version such asopenjdk version "25".Change
Replace the GNU-only regex with a portable one:
Verification
On macOS (Darwin), after the change:
One-line change, no behavioral impact on Linux/GNU grep.