Skip to content

Fix GUI canvas hit testing and strengthen connection tests - #251

Open
zasexton wants to merge 2 commits into
SimVascular:masterfrom
zasexton:issue-250
Open

zasexton wants to merge 2 commits into
SimVascular:masterfrom
zasexton:issue-250

Conversation

@zasexton

Copy link
Copy Markdown
Contributor

Current situation

Closes #250.

Changing boundary-condition controls can leave Cytoscape's cached canvas bounds stale, causing missed connections and export validation errors. Refresh the bounds after visibility changes and verify connections through the GUI's mouse-event handlers.

Release Notes

  • Fix connection hit testing and verify graph edges, exported JSON, and rejection of incomplete networks.
  • Retain CI screenshots and videos for seven days; use npm ci and wait for Flask.
  • Correct Cypress commands and remove the unused drag helper dependency.

Documentation

Updated GUI test instructions and artifact guidance in tests/README.md, plus command examples in the Cypress configuration.

Testing

  • 8/8 tests passed locally in Electron 118 and Chrome 145, including 1000 × 660 and 1920 × 1080 viewport coverage.
  • Regression tests reproduced missed connections before the bounds refresh and passed afterward.
  • Dependency installation, JavaScript syntax, JSON formatting, workflow validation, and diff checks passed.

Code of Conduct & Contributing Guidelines

Refresh Cytoscape bounds when the boundary-condition controls move the canvas. Drive connection gestures through rendered node positions and wait for each edge preview before releasing the mouse. Check graph topology, exported data, nearby nodes at two viewport sizes, and rejected incomplete networks. Remove the unused drag helper and repair the local test commands. Refs SimVascular#250.
Record Cypress videos and upload screenshots and videos separately for each CI platform on failure. Keep artifacts for seven days, wait for Flask before testing, and install the locked dependencies. Document the local test commands and ignore generated artifacts. Refs SimVascular#250.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent macOS GUI test failure in Inflow → Vessel → OUT

1 participant