Repository navigation
Conversation
Refresh Cytoscape bounds when the boundary-condition controls move the canvas. Drive connection gestures through rendered node positions and wait for each edge preview before releasing the mouse. Check graph topology, exported data, nearby nodes at two viewport sizes, and rejected incomplete networks. Remove the unused drag helper and repair the local test commands. Refs SimVascular#250.
Record Cypress videos and upload screenshots and videos separately for each CI platform on failure. Keep artifacts for seven days, wait for Flask before testing, and install the locked dependencies. Document the local test commands and ignore generated artifacts. Refs SimVascular#250.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current situation
Closes #250.
Changing boundary-condition controls can leave Cytoscape's cached canvas bounds stale, causing missed connections and export validation errors. Refresh the bounds after visibility changes and verify connections through the GUI's mouse-event handlers.
Release Notes
npm ciand wait for Flask.Documentation
Updated GUI test instructions and artifact guidance in
tests/README.md, plus command examples in the Cypress configuration.Testing
Code of Conduct & Contributing Guidelines