Skip to content

726: Separate required PR tests from full main-branch validation - #728

Merged
bearsontheloose merged 2 commits into
SimVascular:mainfrom
bearsontheloose:enhancement/726-clarify-required-tests-check
Oct 27, 2026
Merged

bearsontheloose merged 2 commits into
SimVascular:mainfrom
bearsontheloose:enhancement/726-clarify-required-tests-check

Conversation

@bearsontheloose

Copy link
Copy Markdown
Collaborator

Current situation

The purposes of the fast and full test workflows are not clear from their current names and triggers.

The fast workflow is named tests.yml, its run_full_tests output actually controls fast tests, and its required All Tests check is easy to confuse with the separate Full Tests workflow.

Fast Tests and Full Tests also both run after pushes to main, duplicating the unit tests and rank-1 and rank-3 integration tests.

Closes #726.

Release Notes

  • Rename tests.yml to fast-tests.yml.
  • Rename the workflow from Tests to Fast Tests.
  • Run Fast Tests only on pull requests.
  • Continue using optimized Release builds with rank-1 and rank-3 integration tests for required PR validation.
  • Rename run_full_tests to run_tests.
  • Rename the all-tests job to required-tests-summary.
  • Rename the required check from All Tests to Required Tests Summary.
  • Fail the summary check when the test-execution decision cannot be determined.
  • Leave Full Tests responsible for comprehensive validation on pushes to main.
  • Leave the Full Tests manual and labeled-PR triggers unchanged.

Documentation

  • Document the distinct responsibilities, configurations, and triggers of Fast Tests and Full Tests.
  • Document Required Tests Summary as the required branch-protection check.
  • Document the existing check-license-lines, documentation, and review-policy requirements.

Branch Protection

After Required Tests Summary completes successfully on this PR:

  1. Edit the main branch protection rule.
  2. Add Required Tests Summary from GitHub Actions.
  3. Remove All Tests.
  4. Leave check-license-lines, documentation, and review-policy unchanged.
  5. Leave Require branches to be up to date before merging enabled.
  6. Save the rule and confirm that this PR is mergeable.
  7. Merge this PR immediately after updating the rule.
  8. Update in-flight PR branches from main so they run the renamed required check.

Testing

  • Parsed fast-tests.yml successfully.
  • Verified the workflow has only the pull_request trigger.
  • Verified the optimized rank-1 and rank-3 configuration.
  • Verified the renamed output, job ID, and visible check name.
  • Verified that stale Fast Tests names and references were removed.
  • Verified that full-tests.yml is unchanged.
  • git diff --check passes.
  • GitHub Actions behavior will be verified on this PR.

Code of Conduct & Contributing Guidelines

@aabrown100-git aabrown100-git left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bearsontheloose bearsontheloose added the OOP Refactor Object-Oriented Programming Refactor of Code label Oct 24, 2026
@bearsontheloose
bearsontheloose removed the request for review from zasexton October 24, 2026 00:55
@bearsontheloose bearsontheloose removed the OOP Refactor Object-Oriented Programming Refactor of Code label Oct 24, 2026

@zasexton zasexton left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also believe that this looks good

@bearsontheloose
bearsontheloose merged commit 6901ebf into SimVascular:main Oct 27, 2026
12 of 14 checks passed
@bearsontheloose
bearsontheloose deleted the enhancement/726-clarify-required-tests-check branch October 27, 2026 15:32

This branch was previously deployed

1 inactive deployment
review-policy — 5cdfb3dd Deployed Oct 27, 2026 by bearsontheloose via evaluate #1494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate required PR tests from full main-branch validation

3 participants