Repository navigation
724: Establish common solver math layer - #727
Merged
bearsontheloose merged 9 commits intoOct 27, 2026
Merged
bearsontheloose merged 9 commits into
bearsontheloose merged 9 commits into
Conversation
bearsontheloose
temporarily deployed
to
review-policy
October 23, 2026 17:03 — with
GitHub Actions
Inactive
zasexton
reviewed
Oct 26, 2026
zasexton
approved these changes
Oct 26, 2026
zasexton
left a comment
Collaborator
There was a problem hiding this comment.
I think this all looks good; I just left a minor question
zasexton
temporarily deployed
to
review-policy
October 26, 2026 18:18 — with
GitHub Actions
Inactive
bearsontheloose
temporarily deployed
to
review-policy
October 26, 2026 23:54 — with
GitHub Actions
Inactive
michelebucelli
approved these changes
Oct 27, 2026
bearsontheloose
temporarily deployed
to
review-policy
October 27, 2026 16:59 — with
GitHub Actions
Inactive
bearsontheloose
temporarily deployed
to
review-policy
October 27, 2026 17:12 — with
GitHub Actions
Inactive
bearsontheloose
temporarily deployed
to
review-policy
October 27, 2026 17:47 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current situation
The solver’s reusable Matrix, Vector, and dense linear algebra utilities currently live under FE/Math and use the svmp::FE::math namespace. These utilities are not inherently FE-specific and are already used outside the FE implementation.
As proposed in #724, they should form a small, reusable math component under solver/common/math, with a public include boundary and a dedicated CMake target. This establishes the first low-level component boundary identified in #676 without redesigning the existing math APIs.
Closes #724.
Release Notes
##Documentation
##Testing
Code of Conduct & Contributing Guidelines