Repository navigation
Remove the unused NOX include and C++ standard flag for Trilinos builds - #716
Merged
Merged
Conversation
trilinos_impl.h uses nothing from NOX, so the include only prevented builds against Trilinos without NOX. The appended -std flag had no effect because CMake adds the standard flag after CMAKE_CXX_FLAGS.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
zasexton
temporarily deployed
to
review-policy
October 20, 2026 21:59 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
+ Coverage 73.43% 73.45% +0.01%
==========================================
Files 281 281
Lines 40720 40768 +48
Branches 6762 6770 +8
==========================================
+ Hits 29903 29945 +42
- Misses 10561 10567 +6
Partials 256 256 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zasexton
temporarily deployed
to
review-policy
October 23, 2026 01:47 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
sujaldave
approved these changes
Oct 23, 2026
sujaldave
left a comment
sujaldave
left a comment
There was a problem hiding this comment.
Apologies for taking time on this.
To be sure I wasn't using NOX even during runtime (somehow on Kokkos or TPetra) on CPUs and GPUs - I built the branch on Sherlock CPUs and GPUs and ran simple fluid/fsi pipe3D tests as well. All successful. Agree with the two minor removals.
kko27
approved these changes
Oct 28, 2026
zasexton
temporarily deployed
to
review-policy
October 28, 2026 02:40 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
bearsontheloose
approved these changes
Oct 28, 2026
bearsontheloose
left a comment
bearsontheloose
left a comment
Collaborator
There was a problem hiding this comment.
This looks good.
zasexton
temporarily deployed
to
review-policy
October 29, 2026 01:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current situation
trilinos_impl.hincludesNOX_TpetraTypedefs.hppbut uses nothing from NOX, so the solver cannot be built against a Trilinos installation without NOX. Trilinos builds also append-std=c++${CMAKE_CXX_STANDARD}, which has no effect because CMake adds its own standard flag after it. This PR removes the include and the flag.Fixes #709.
Release Notes
Documentation
No documentation changes are needed.
Testing
Code of Conduct & Contributing Guidelines