Repository navigation
Link threads, BLAS/LAPACK, and VTK more precisely - #712
Conversation
Link the unit tests with the Threads::Threads target that find_package(Threads) already provides, require BLAS and LAPACK with 32-bit integers to match the solver's int arguments, and request only the five VTK modules the solver uses.
|
@ktbolt what do you think of explicitly linking only the needed components of VTK for solver builds? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
==========================================
+ Coverage 73.43% 73.45% +0.01%
==========================================
Files 281 281
Lines 40720 40768 +48
Branches 6762 6770 +8
==========================================
+ Hits 29903 29945 +42
- Misses 10561 10567 +6
Partials 256 256 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@zasexton Explicitly linking only the needed components of VTK for solver builds is the right thing to do; this is what I do when I build against my local VTK install that just builds VTK with these components that are needed just for reading/writing VTK files. |
|
@claude review |
bearsontheloose
left a comment
There was a problem hiding this comment.
This looks good.
|
@ktbolt if you think these changes are good then I'll try to go ahead and merge this in today |
Current situation
The unit tests link
pthreadby name,find_package(BLAS)andfind_package(LAPACK)may select a library with 64-bit integers although the solver passes 32-bitintarguments, andfind_package(VTK)links every installed VTK module. This PR linksThreads::Threads, setsBLA_SIZEOF_INTEGERto 4, and requests only the VTK components the solver uses:CommonCore,CommonDataModel,CommonMisc,FiltersGeometry, andIOXML.Fixes #705.
Release Notes
Documentation
No documentation changes are needed.
Testing
pipe_RCR_3d, structblock_compression, and electrophysiologycable_TTP_1dtests and theustructtests (36 runs).Code of Conduct & Contributing Guidelines