Skip to content

Link threads, BLAS/LAPACK, and VTK more precisely - #712

Merged
zasexton merged 6 commits into
SimVascular:mainfrom
zasexton:issue-705
Oct 30, 2026
Merged

zasexton merged 6 commits into
SimVascular:mainfrom
zasexton:issue-705

Conversation

@zasexton

Copy link
Copy Markdown
Collaborator

Current situation

The unit tests link pthread by name, find_package(BLAS) and find_package(LAPACK) may select a library with 64-bit integers although the solver passes 32-bit int arguments, and find_package(VTK) links every installed VTK module. This PR links Threads::Threads, sets BLA_SIZEOF_INTEGER to 4, and requests only the VTK components the solver uses: CommonCore, CommonDataModel, CommonMisc, FiltersGeometry, and IOXML.

Fixes #705.

Release Notes

  • Link only the VTK modules the solver uses, and require BLAS and LAPACK with 32-bit integers.

Documentation

No documentation changes are needed.

Testing

  • Built the solver and passed the unit tests.
  • Passed the fluid pipe_RCR_3d, struct block_compression, and electrophysiology cable_TTP_1d tests and the ustruct tests (36 runs).

Code of Conduct & Contributing Guidelines

Link the unit tests with the Threads::Threads target that find_package(Threads)
already provides, require BLAS and LAPACK with 32-bit integers to match the
solver's int arguments, and request only the five VTK modules the solver uses.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@zasexton
zasexton requested a review from ktbolt October 20, 2026 20:05
@zasexton

Copy link
Copy Markdown
Collaborator Author

@ktbolt what do you think of explicitly linking only the needed components of VTK for solver builds?

@zasexton
zasexton requested a review from sujaldave October 20, 2026 20:31
@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.45%. Comparing base (8df7565) to head (aa7bf08).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
+ Coverage   73.43%   73.45%   +0.01%     
==========================================
  Files         281      281              
  Lines       40720    40768      +48     
  Branches     6762     6770       +8     
==========================================
+ Hits        29903    29945      +42     
- Misses      10561    10567       +6     
  Partials      256      256              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ktbolt

ktbolt commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

@zasexton Explicitly linking only the needed components of VTK for solver builds is the right thing to do; this is what I do when I build against my local VTK install that just builds VTK with these components that are needed just for reading/writing VTK files.

@bearsontheloose bearsontheloose self-assigned this Oct 28, 2026
@bearsontheloose

Copy link
Copy Markdown
Collaborator

@claude review

@bearsontheloose bearsontheloose removed their assignment Oct 28, 2026
@bearsontheloose
bearsontheloose self-requested a review October 28, 2026 15:56

@bearsontheloose bearsontheloose left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Comment thread Code/Source/solver/CMakeLists.txt Resolved
@zasexton
zasexton requested a review from kko27 October 29, 2026 01:35
@zasexton

Copy link
Copy Markdown
Collaborator Author

@ktbolt if you think these changes are good then I'll try to go ahead and merge this in today

@ktbolt ktbolt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zasexton
zasexton merged commit fa4dd10 into SimVascular:main Oct 30, 2026
11 checks passed

This branch was previously deployed

1 inactive deployment
review-policy — 1ddd0661 Deployed Oct 30, 2026 by zasexton via evaluate #1965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link threads, BLAS/LAPACK, and VTK more precisely

3 participants