Repository navigation
Warn before loading custom deadcode plugins - #1034
Merged
Merged
Conversation
`spoom deadcode` requires every `.spoom/deadcode/plugins/*.rb` file from the analyzed project, which executes that project's Ruby code. This is how custom plugins are designed to work, but it isn't obvious, so print a warning listing the files before loading them and document the behavior in the README. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
egiurleo
force-pushed
the
deadcode-custom-plugins-warning
branch
from
October 16, 2026 16:53
204d145 to
94b59dc
Compare
KaanOzkan
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
spoom deadcodeautomaticallyrequires every.spoom/deadcode/plugins/*.rbfile in the analyzed project. That's how custom plugins are designed to work, but it means runningspoom deadcodeon an untrusted checkout runs that checkout's Ruby code, and nothing says so.We decided to keep the behavior as designed (running any tool in an untrusted folder is already risky). This PR just makes it visible.
Implementation
spoom deadcodeprints a warning listing them before requiring them. Projects without custom plugins see no change in output.Tests
Updated
test_deadcode_load_custom_pluginsto assert the warning.test_deadcode_show_plugins_defaultstill passes unchanged, which confirms there's no warning when no custom plugins exist.