Skip to content

A box round a picture spans the width in a terminal again - #53

Merged
HarryCordewener merged 1 commit into
mainfrom
claude/mxp-terminal-images-4fnuyf
Oct 8, 2026
Merged

HarryCordewener merged 1 commit into
mainfrom
claude/mxp-terminal-images-4fnuyf

Conversation

@HarryCordewener

Copy link
Copy Markdown
Member

Before: since 2.14.2 (#51), a box holding only a picture is fitted to the picture in a terminal. In a scene log that box is narrower than every other pose's box and rule around it.

After: the box spans the width like a box round text, with its padding, and the picture sits at its left. HTML still fits it (ms-box-picture).

How: reverts the Frame and Figure parts of #51. ABoxRoundOnlyAPictureSpansTheWidth replaces the three fitting tests. Build is warning-free and all 1101 tests pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_018ztDNVgzxM8V5WKWBRs2EW


Generated by Claude Code

2.14.2 (#51) fitted a box holding only a picture to the picture. In a scene
log that box stood narrower than every other pose's box and rule. It is drawn
across the width again, with its padding, and the picture at its left. HTML
keeps fitting it (ms-box-picture).

This reverts the Frame and Figure parts of 62345a3.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018ztDNVgzxM8V5WKWBRs2EW
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: d001992e-d360-4cca-8f17-c0c1ec06d5ae
📥 Commits

Reviewing files that changed from the base of the PR and between ba0ce27 and 2dcbf77.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • MarkupString.Tests/Ansi/TerminalFeatureTests.cs
  • MarkupString/Layout/Blocks/Figure.cs
  • MarkupString/Layout/Blocks/Frame.cs
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@HarryCordewener
HarryCordewener merged commit b43ceaf into main Oct 8, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants