Repository navigation
Size a figure's MXP picture in the cells laid out for it - #52
Merged
Merged
Conversation
A figure's <IMAGE> carried no size, so a client drew the picture at its own size under the line, outside any box round the figure. The tag now says how many cells the picture covers (W=12c H=5c), the art's or the PictureCells a host gave it, so a client can draw it there. A row that is only the picture's description is marked PictureRow.IsDescription and gets no cell size: a picture squeezed into one line of its description would be a strip. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ztDNVgzxM8V5WKWBRs2EW
|
Warning Review paused — included plan limit reachedKeep your review moving with free on-demand reviews.
On-demand reviews are free for the next 2 days.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Promotion and pricing detailsOn-demand reviews are free for the next 2 days. After that, they cost $0.25 per reviewed file. Review limit detailsOr wait 37 minutes for your next included review. Limit details: You’ve used the included review currently available. Your 83 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (8)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: a figure's
<IMAGE>carried no size, so an MXP client drew the picture at its own size under the line it was named on. Inside a box, the picture landed below the box and the box lost its edges beside it.After: the tag says how many cells the picture covers,
W=7c H=3cfor a 7×3 art, or thePictureCellsa host gave a figure with no art. A client that honours cell sizes draws the picture in those cells, which the emitter already leaves blank.A figure with neither art nor cells only has its
[description]row. That row is now markedPictureRow.IsDescriptionand gets no cell size, since a picture squeezed into one line of text would be a strip. The flag round-trips through the serialiser asdsc.How:
ElementMxpEmitterwritesW/HfromImageMarkup.Row(columns and rows, suffixedc) unless the row is a description; otherwise the pixel sizes as before.Figure.MarkedsetsIsDescriptionon the described path.Companion changes: SharpMUSH lays figures out with picture cells for MXP clients, and SharpMUTerm draws into reserved cells instead of adding rows.
🤖 Generated with Claude Code
https://claude.ai/code/session_018ztDNVgzxM8V5WKWBRs2EW
Generated by Claude Code