Skip to content

Keep percentage flex columns on the same HTML row - #43

Merged
HarryCordewener merged 1 commit into
mainfrom
codex/html-flex-percent-gap
Oct 7, 2026
Merged

HarryCordewener merged 1 commit into
mainfrom
codex/html-flex-percent-gap

Conversation

@HarryCordewener

Copy link
Copy Markdown
Member

Summary

  • reserve inter-item spacing before resolving percentage flex bases in HTML, matching terminal layout
  • include divider border and padding within each flex item’s declared size
  • add a regression test for two 50% columns separated by │

This fixes the HTML-only wrap exposed while preparing the screenshots in #42.

Verification

  • dotnet build MarkupString.slnx --no-restore --disable-build-servers
  • dotnet run --no-build --project MarkupString.Tests (1,031 passed)

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Warning

Review paused — included plan limit reached

Keep your review moving with free on-demand reviews.

  • Run this review for free

On-demand reviews are free for the next 2 days.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Promotion and pricing details

On-demand reviews are free for the next 2 days. After that, they cost $0.25 per reviewed file.

Review limit details

Or wait 49 minutes for your next included review.

Check out review usage here.

Limit details: You’ve used the included review currently available. Your 81 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: ebc72eda-af52-4a74-8e98-0a0c6c9b2104
📥 Commits

Reviewing files that changed from the base of the PR and between 52bd924 and a4f3e36.

📒 Files selected for processing (3)
  • MarkupString.Html/Emitters/LayoutHtml.cs
  • MarkupString.Html/LayoutCss.cs
  • MarkupString.Tests/Layout/BlockLayoutTests.cs
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@HarryCordewener
HarryCordewener merged commit f8b82c4 into main Oct 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant