Repository navigation
Hide a filling table's colgroup on narrow pages instead of !important - #39
HarryCordewener wants to merge 1 commit into
Conversation
…g its widths with !important
The 48em rule gave up the columns' shares with `col { width: auto !important; }`. Hiding the
colgroup drops the inline widths the same way (checked in Chromium: a 80%/20% colgroup at 600px
lays out 348/235 with it, 69/514 hidden, the same as no colgroup), and a host whose stylesheets
refuse !important, such as SharpMUSH's portal, can carry the rule as written. The changelog also
gets the 2.11.0 heading the grow entry shipped under.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eAjtsQTFqWAeWQMc7ebNo
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. WalkthroughAt viewport widths up to ChangesFilled table layout
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The narrow-page table change is reflected in its test and changelog. No actionable merge risk is established by the supplied changes; proceed with normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Comment |
Before: on a page under 48em,
LayoutCssgave up a filling table's column shares with.ms-table.ms-fill > colgroup > col { width: auto !important; }. SharpMUSH's portal copiesLayoutCss.Fixedintoshell.cssand refuses!importantin its global stylesheets, so its two tests contradict each other and SharpMUSH #1648 can't go green on 2.11.0.After: the rule is
.ms-table.ms-fill > colgroup { display: none; }. In Chromium at 600px, an 80%/20% colgroup lays out at 348/235 px. With the colgroup hidden it lays out at 69/514, the same as a table with no colgroup.How: one CSS rule and its test. The changelog gets the
2.11.0heading the grow entry shipped under, with this fix under Unreleased. It needs a 2.11.1 release for SharpMUSH to pick up.🤖 Generated with Claude Code
https://claude.ai/code/session_018eAjtsQTFqWAeWQMc7ebNo
Generated by Claude Code
Summary by CodeRabbit