Lucy.py single entry - #51
Closed
Arcod7 wants to merge 4 commits into
Closed
Conversation
Lucy.py imported curses at module level, so on Windows it died before doing anything. There is also no tmux there to drive the TUI. Import curses lazily, and on Windows run install.py when the workspace is not built, then print the pixi tasks to start by hand. install.py runs with the terminal attached so its pixi and MSVC prompts are answerable. is_installed() also checks install/setup.bat, which is what colcon writes on Windows.
…-exports releases.json and releases.nsh are written by generate_releases.py, which both build paths run first, so tracking them only commits an artifact that drifts. Gitignore them instead. build_installer.ps1 is referenced by nothing in CI and duplicates the steps CI already runs, in PowerShell. The Windows README now lists those steps directly, so there is no wrapper to fall out of sync. install_ops re-exported 25 names from install.py; install_runner.py, Lucy.py and CI together reach for 8. Keep those.
With no arguments Lucy.exe handed off to launch_lucy.sh, which on Windows ends at the curses TUI — no curses, no tmux — so the Start Menu and Desktop shortcuts the installer creates have never worked. They point at Lucy.exe with no arguments, and the .exe is the main Windows install path. It now installs when the workspace is missing and otherwise names the pixi tasks, matching what python3 Lucy.py does. The --cli mode Lucy-Setup.exe drives is untouched. Dropping the launcher half also retires run_command, _find_git_bash and the subprocess import. Also corrects a comment claiming windows/Lucy.py reads install_ops directly; it reaches it through install_runner.
Lucy.exe is built elsewhere now, so windows/ has no consumer here: Lucy.py, install_runner.py, install_ops.py, generate_releases.py, installer/Lucy.nsi and the icon all existed only to produce Lucy.exe and Lucy-Setup.exe. windows-build-test and build-and-release-windows-exe go with them — every step they ran pointed inside windows/, so they had nothing left to build. pixi-install-build-test is untouched and still covers all six platforms including windows-latest. One fact lived only in windows/README.md and is now in the root README and the developer guide: pixi resolves win-64 on Windows-on-ARM too, because pixi.lock has no win-arm64.
Contributor
Author
|
Superseded by #53 (branch renamed to aes/windows-entrypoint-cleanup). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OP#196