Repository navigation
Give the server setup a screen of its own, and fix what a pass over the panel found - #53
Merged
Merged
Conversation
…abelled players in the online column, and fit the profile and audit tables
…e 0, which MIB_TCP_STATE leaves undefined
…cutables rather than batch scripts
…y their fill alone, without the accent notch
…secrets, for the owner choosing server.cfg
…l-screen flow outside the panel's shell
…ail, a file browser to pick server.cfg and a first-launch page
…o show it as the builds page does
… build selected or recommended, as the mockups draw them
…panel no longer throws during development
…answers 502, 503 or 504 in its place
# Conflicts: # web/src/shell/AppShell.tsx
…hout the accent notch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server setup leaves the panel's shell for a full-screen flow: a step rail, a file browser to pick server.cfg, the folder check's verdict before Continue, and a first-launch page. Alongside, a pass over the panel fixes what it found: the console losing its lines while a command is sent, tables that scrolled sideways, the accent notch on selected rows, and two errors that only Windows 11 build 26300 and a reverse proxy brought out.
What changed
/server/setup): a screen of its own, outside the rail and the online column (FocusShell, onSignedIn, which every signed-in screen now shares). Each step asks its question as the page heading, with its buttons in a bar at the foot, and the step rail shows what each step chose.POST /servers/default/setup/fileslists a folder inside the server folder, andPOST /servers/default/setup/cfg/textreturns a cfg with its secrets masked (observer-fxserver,server_files). Both take what reading the launch settings takes.observer-platform: Windows 11 build 26300 lists every listening TCP socket in state 0, a valueMIB_TCP_STATEdoes not define (closed is 1, listening 2). State 0 now counts as listening; before, Observer saw no listener at all on such a host, and five tests failed.xtask: npm and npx run where a Node manager installs them as executables rather than.cmdscripts.en.tsduring development keeps one context instead of throwinguseI18n must be used inside <I18nProvider>.Notes for review
mainis merged in (ff0de00): one conflict, inAppShell.tsx, between this branch's flatter shell and the update signal at the rail's foot. Both are kept.GetExtendedTcpTableon build 26300, wherenetstathides those sockets.Verified
mainataaced3f:cargo xtask checkpasses whole: fmt, icons, clippy with-D warningswith and withoutobserver/test-catalog, 3056 tests, bindings unchanged, and the panel's format, lint, type check, 691 tests and build. The panel ran under Node 26.13: this machine has no Node 24, and jsdom 31 refuses Node 22.16.mainon this machine pass here.Not verified
cargo xtask e2e: Playwright's browsers are not installed here.