fix(query): cheaper exact-flat retain + deadline backstop - #539
Conversation
Exact-flat scans and first-query lexical projection stays O(store); a missing caller deadline no longer leaves those paths unbounded.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e32b35160
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Score every visited row, but clone candidate/evidence only for the cap that the heap keeps. Isolated test: 4 examined, 2 materialized.
8fa116b
into
codex/tracedecay-total-redesign-plan
Summary
fa9c6318(merge of fix(privacy): close the remaining Codex P1 gaps after #522 merged #537). Query crate work plus the forcedSemanticVectorReadPortexamine adapt in usecases so the trait change compiles.deadline_microsfalls back to crate 5s (semantic) / 30s (lexical projection build). A set request/profileRetrievalBudget.deadline_microswins (Plan 20, same bar as feat(automation): Plan 26 typed BudgetExceeded backoff for session_evidence_budget_exhausted #538).BudgetExceededstays Partial, never a complete empty success. Semantic 5s does not take down exact/lexical/graph (required lanes stay exact+lexical).examineruns before every inspected row, including excluded ones; lexical projection/fuzzy/n-gram build checkpoints the same deadline.Test plan
cargo test -p tracedecay-query --lib retrieval::semantic::tests(28 passed)cargo test -p tracedecay-query --lib retrieval::lexical(20 passed)cargo test -p tracedecay-query --lib retrieval::tests::composition(16 passed, includingsemantic_budget_exceeded_does_not_take_down_exact_lexical_or_graph)Does not reopen #532. Do not merge until CI is green.