fix: minor fixes for client side datasets api migration v3 to v4 - #2947
Open
Junjiequan wants to merge 4 commits into
Open
fix: minor fixes for client side datasets api migration v3 to v4#2947Junjiequan wants to merge 4 commits into
Junjiequan wants to merge 4 commits into
Conversation
Junjiequan
force-pushed
the
prep-for-client-migration-dataset-v3-to-v4
branch
from
September 8, 2026 07:47
ca12ad9 to
a6405a4
Compare
Junjiequan
force-pushed
the
prep-for-client-migration-dataset-v3-to-v4
branch
from
September 9, 2026 07:32
38439f4 to
cfbed7f
Compare
HayenNico
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
{$gte: {$date: "..."}}. nothing converts that marker, so it reached mongo as a plain object instead of a Date and the filter matched nothing.castWhereFilterconverts it before the pipeline runs, and is written as a marker map so other extended json types can be added laterdate.beginanddate.endonly when a value is provided$text,$search,$dateAdditional bug fix:
@ApiParamand the route on the attachment delete endpoint, which was generating a not needed requiredidfield in the sdkMotivation
Fixes
Changes:
Tests included
Documentation
official documentation info
Summary by Sourcery
Fix dataset filter handling and attachment API metadata for the v3-to-v4 client migration.
Bug Fixes:
Enhancements: