Repository navigation
Fix LabyMod crash on Essential chat components - #42
Merged
Merged
Conversation
Convert non-vanilla chat components to vanilla ones before they are serialized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert non-vanilla chat components to vanilla ones before they are serialized.
LabyMod serializes chat lines to JSON, and vanilla throws a "Don't know how to serialize ... as a Component" error for any chats that aren't a ChatComponentText component. Essential's
UTextComponentisn't one, so it crashes the entire game when using LabyMod./essential,/essential config, and anything else using UTextComponent would crash the game when using LabyMod.This fix patches
IChatComponent$Serializerto pass it throughChatComponentSanitizer, which copies the unknown components intoChatComponentTextcomponents with the same text, style, and siblings.The class is still obfuscated when the transformer runs, so the method is found through its descriptor.
This fix is likely only for 1.8.9 since 1.12.2 has a different name for the class.
Tested on 1.8.9 with LabyMod 3
Fixes #33