Repository navigation
fall back to the API when a datastream entity fetch times out - #127
Merged
Merged
Conversation
cbrady
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the datastream did not return a company or user within 2 seconds,
DataStreamClient.checkFlagevaluated the flag against a null entity and returned that result as authoritative, so rules targeting the company were skipped. NowcheckFlagthrowsDataStreamExceptionwhen an entity the caller named cannot be fetched, and the wrapper's existing REST fallback answers the check. This matches the Go, Node, Python and Ruby SDKs. In SDK E2E run https://github.com/SchematicHQ/schematic-api/actions/runs/41110052599 the dev datastream took 4 seconds to serve a company; Java returned the right value there only because that flag had no company rules.getCompanyandgetUserstill return null on a miss, since the credit lease check relies on that to defer to a plain check.