Repository navigation
SCH-7988 raise the server-mode reservation TTL cap to 24 hours - #126
Merged
Merged
Conversation
ryanechternacht
marked this pull request as ready for review
October 28, 2026 02:19
bpapillon
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API now accepts a reservation
expiresAtup to 24 hours out (SchematicHQ/schematic-api#9736). This client still clamped the configured reservation TTL to just under one hour in server mode, so a longer hold never reached the server. The cap is now 24 hours, with the same 60-second skew allowance. Client mode is unchanged.Locally,
WasmRulesEngineTestandWasmRulesEngineClockTestfail to initialize the WASM rules engine, and they fail the same way on main; every other test passes on JDK 11.Part of SCH-7988