Repository navigation
chore(tests): read quantity_rates from the typed entitlement field - #122
Merged
Merged
Conversation
bpapillon
marked this pull request as ready for review
October 15, 2026 00:25
cbrady
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main has failed since #119 merged. That PR was based on a commit before #120 regenerated the SDK, and its test read quantity_rates out of the entitlement's additionalProperties. #120 gave RulesengineFeatureEntitlement a typed quantityRates field, so the value no longer lands in additionalProperties and the assertion saw null. The test now reads the typed getter. Unblocks the v0.11.0 WASM bump in #121.