Repository navigation
Adding bifrustum model - #790
Open
sara-mokhtari wants to merge 4 commits into
Open
sara-mokhtari wants to merge 4 commits into
sara-mokhtari wants to merge 4 commits into
Conversation
sara-mokhtari
requested review from
pkienzle
and
a balanced review from Copilot
November 8, 2026 14:12
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
There was a problem hiding this comment.
No quality gates enabled for this code.
See analysis details in CodeScene
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
pkienzle
approved these changes
Nov 10, 2026
pkienzle
left a comment
Contributor
There was a problem hiding this comment.
Code looks okay. Models run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #772
Adds a pure-Python
bifrustummodel (truncated bipyramid with a regular polygonal cross-section).Depends on #781 (support for pure Python 2D models): this PR is based on
py-Iqabcand targets it,so the diff only shows the bifrustum. Once #781 is merged, I will retarget this PR to
masterand merge
masterinto this branch.handled by the closed-form expressions of Yang et al. (doi:10.1107/S160057672201130X)
Fqabc/Iqabcwiththeta,phi,psiNote for review: computational optimizations were added (shared vertices: explained inside the code and documentation).
How Has This Been Tested?
model_testpassesReview Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)