Repository navigation
226: HDF5 display name fix - #256
Merged
Merged
Conversation
…all back to the entry_key value
… using for HDF5 files
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
No quality gates enabled for this code.
See analysis details in CodeScene
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
ps1401
approved these changes
Nov 7, 2026
ps1401
left a comment
ps1401
left a comment
There was a problem hiding this comment.
All good, just one set of updates to do.
| test_file = "../../../sasdata/example_data/2d_data/BAM_2D.h5" | ||
| # test_file = "../example_data/2d_data/14250_2D_NoDetInfo_NXcanSAS_v3.h5" | ||
| # test_file = "../example_data/2d_data/33837rear_2D_1.75_16.5_NXcanSAS_v3.h5" | ||
| #test_file = "../../../test/test_files/data/nxcansas_1Dand2D_multisasdata.h5" |
There was a problem hiding this comment.
As discussed, change all file addresses to match the format of the BAM_2D.h5 file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the name of the HDF5 file to use the metadata title instead of the root_key so all NXcanSAS files are no longer
sasentry01.This replaces #254.