Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
import com.google.firebase.messaging.FirebaseMessaging;
import com.google.firebase.messaging.FirebaseMessagingException;
import com.google.firebase.messaging.Message;
import com.google.firebase.messaging.MessagingErrorCode;
import com.swyp.picke.domain.notification.entity.UserDevice;
import com.swyp.picke.domain.notification.repository.UserDeviceRepository;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.springframework.stereotype.Service;
Expand All @@ -18,6 +20,7 @@
public class FcmPushService {

private final FirebaseMessaging firebaseMessaging;
private final UserDeviceRepository userDeviceRepository;

/**
* Android 디바이스에 FCM data-only 메시지를 발송한다.
Expand All @@ -40,6 +43,9 @@ public void send(UserDevice device, String title, String body, Map<String, Strin
firebaseMessaging.send(message);
} catch (FirebaseMessagingException e) {
log.warn("FCM 푸시 전송 실패. deviceId={}, error={}", device.getId(), e.getMessage());
if (e.getMessagingErrorCode() == MessagingErrorCode.UNREGISTERED) {
userDeviceRepository.deleteById(device.getId());
}
}
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
package com.swyp.picke.global.infra.fcm.service;

import com.google.firebase.messaging.FirebaseMessaging;
import com.google.firebase.messaging.FirebaseMessagingException;
import com.google.firebase.messaging.Message;
import com.google.firebase.messaging.MessagingErrorCode;
import com.swyp.picke.domain.notification.entity.UserDevice;
import com.swyp.picke.domain.notification.enums.DevicePlatform;
import com.swyp.picke.domain.notification.repository.UserDeviceRepository;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.ArgumentCaptor;
Expand All @@ -15,6 +18,10 @@

import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.doThrow;
import static org.mockito.Mockito.lenient;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;

@ExtendWith(MockitoExtension.class)
Expand All @@ -23,9 +30,12 @@ class FcmPushServiceTest {
@Mock
private FirebaseMessaging firebaseMessaging;

@Mock
private UserDeviceRepository userDeviceRepository;

@Test
void send_includes_title_and_body_in_data_payload() throws Exception {
FcmPushService fcmPushService = new FcmPushService(firebaseMessaging);
FcmPushService fcmPushService = new FcmPushService(firebaseMessaging, userDeviceRepository);
UserDevice device = buildDevice();

fcmPushService.send(device, "제목", "본문", Map.of("type", "TEST"));
Expand All @@ -39,6 +49,34 @@ void send_includes_title_and_body_in_data_payload() throws Exception {
assertThat(data).containsEntry("type", "TEST");
}

@Test
void send_deletes_device_when_token_is_unregistered() throws Exception {
FcmPushService fcmPushService = new FcmPushService(firebaseMessaging, userDeviceRepository);
UserDevice device = buildDevice();

FirebaseMessagingException exception = mock(FirebaseMessagingException.class);
lenient().when(exception.getMessagingErrorCode()).thenReturn(MessagingErrorCode.UNREGISTERED);
doThrow(exception).when(firebaseMessaging).send(any(Message.class));

fcmPushService.send(device, "제목", "본문", Map.of("type", "TEST"));

verify(userDeviceRepository).deleteById(device.getId());
}

@Test
void send_keeps_device_when_error_is_not_unregistered() throws Exception {
FcmPushService fcmPushService = new FcmPushService(firebaseMessaging, userDeviceRepository);
UserDevice device = buildDevice();

FirebaseMessagingException exception = mock(FirebaseMessagingException.class);
lenient().when(exception.getMessagingErrorCode()).thenReturn(MessagingErrorCode.UNAVAILABLE);
doThrow(exception).when(firebaseMessaging).send(any(Message.class));

fcmPushService.send(device, "제목", "본문", Map.of("type", "TEST"));

verify(userDeviceRepository, never()).deleteById(any());
}

@SuppressWarnings("unchecked")
private Map<String, String> extractData(Message message) throws Exception {
Field dataField = Message.class.getDeclaredField("data");
Expand Down
Loading