Repository navigation
feat: a seabed drift note and initialisation notes for in-process hosts - #100
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c114ba0fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…eabed With no seabed friction a current moves grounded nodes freely along the seabed, and nothing in a run says so. A dynamic deck with an interior line node in contact at the converged static state, a current on the line and no friction now prints one initialisation note for the run, naming the lines and frictionMu. Where the route rejects frictionMu the note says so instead of asking for it. The note covers EI = 0 and finite-EI lines on the standalone routes, and the coupled aggregate with the current known at initialisation (the deck's, or the host's steady current). A run that marches no step prints nothing. No result changes. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The note gave a drift distance that was never measured. It now says what holds: nothing holds the grounded nodes against the current, so the layout can drift along the seabed through the run. The note test gains a TURBINES deck on its motionFile record, and the shipped lazy wave, silent at its own TMax = 0 and noted on a short march. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The row editor could match a comment that names an option, and leave the option itself as it was. It now skips comments, and the test checks that a shipped deck keeps one TMax row. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
An in-process host saw none of the notes the driver and OpenFAST print at the start of a run. CableDyn_GetInitNotes returns the notes of the last deck initialisation on a handle, one per line, on the point route and the aggregate alike, under the buffer conventions of CableDyn_GetLastError; it also returns the whole length, so a null buffer asks for the size. Python reads them as CableDyn.init_notes. The notes of a parse are kept once, although a deck is read twice. The library prints what it printed before. The point route now works out the notes of its lines, which it had no report for. Part of ABI 1 minor extension 4. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The notes of a point system now take the step the deck reports, zero without one, so a deck built on a nominal step gets no dtM advisory. The two module variables of the note capture join the reviewed static storage: they are written only under the process-wide input lock. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The static check gains the TURBINES route: a deck on its per-turbine motionFile record runs without dtM and writes the output of the run with dtM byte for byte. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
A library of ABI minor 4 could predate CableDyn_GetInitNotes, and the lookup sat with the host fluid calls, so importing cabledyn stopped. The call is now optional and only init_notes refuses without it. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
6c114ba to
ec00e2e
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec00e2eb55
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The notes of a line were copied through a 2048-character buffer, shorter than the summary they come from, so a longer note would have been cut. The buffer now has the summary's own length. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Seabed drift note. With no seabed friction a current moves grounded nodes freely along the seabed, with no warning. One initialisation note now appears when a dynamic deck has an interior node in contact at the converged static state, a current on that line and no friction. It names the lines and the remedy (
frictionMu), or says friction is not supported where the route rejects it. It coversEI = 0and finite-EI lines on the standalone routes and the coupled route, with a deck current or a host's steady current. It changes no result.Notes of an initialisation. The C API prints no notes, so an in-process host never saw them.
CableDyn_GetInitNotesreturns the notes of the last initialisation as text, with the buffer conventions ofCableDyn_GetLastError; a NULL buffer asks for the size. Python:CableDyn.init_notes, a list of strings. Part of ABI minor 4. A failed initialisation replaces the notes while the handle keeps its model.Checks
seabed_drift_note: 82 gates, 20 of which fail on the old driver: every case with and without grounded nodes, static-only runs, friction on, zero current, a taut line touching only at its anchor,TURBINESwithmotionFile.TMax 0and print it once given a march.init_notesequals the driver's start and report notes on 6 shipped decks, tested through Python and C. With a host field a deck's steady current gives the note, and a deck with no current gives none.TURBINESdeck atTMax 0withoutdtM.The CHANGELOG entry lands with the release batch.