Fix bytemuck feature after bitflags update - #638
Merged
Conversation
nazar-pc
marked this pull request as draft
August 5, 2026 10:09
Contributor
Author
|
Will have a bit better version in a moment |
nazar-pc
marked this pull request as ready for review
August 5, 2026 10:11
Contributor
Author
|
Okay, better solution is to simply enable |
Member
|
I'm more concerned about this breaking change from bitflags v1 -> v2:
We should probably derive all that, I'll add it along with a check for the bytemuck feature. |
Contributor
Author
|
Makes sense |
Firestar99
reviewed
Aug 5, 2026
Firestar99
enabled auto-merge
August 5, 2026 12:53
Firestar99
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs were not checked in CI, but failed somehow after merging to
main: https://github.com/Rust-GPU/rust-gpu/actions/runs/30995586739/job/92271767273.Copy/Clone derived unconditionally, despite only being needed for
bytemuck. Feel free to update if that is not desirable (I think it is though).