Repository navigation
Read an HTTP 429 that ethers gave up on as a rate limit - #330
Merged
Merged
Conversation
ethers, allowed one try by rpc-provider.js, reports a 429 as "exceeded maximum retry limit", and the 429 is left only in the status of the response it escalated. isRateLimited read the short message alone, so the checker's node, which answers a burst with a 429, still got four quick tries: its first epoch on #329 left 2 agents unread with exactly that error. It now reads the escalated status, and the words ethers uses. A test drives a real 429 through the provider. Oracle tests: 1546. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #329. Its first epoch on the checker (01:19 UTC) still left 2 agents unread, both with
exceeded maximum retry limit.That is how ethers reports an HTTP 429 once its attempts run out.
rpc-provider.jsallows one, so every 429 arrives that way, and the 429 survives only in the status of the response ethers escalated (CLIENT ESCALATED SERVER ERROR (429 Too Many Requests; exceeded maximum retry limit)).isRateLimitedread only the short message, so those reads kept the short schedule. #329's tests built the error by hand with "429" in its words, which is why they did not catch this.What changes (
read-retry.js)isRateLimitedalso reads the escalated response's status, and treats "exceeded maximum retry limit" as a rate limit. ethers says that only when its throttle retries run out.Tests
rpc-provider.test.jsdrives a real HTTP 429 throughrpcProviderfrom a local endpoint. The read must be classed as a rate limit and tried 7 times. It fails on main, andrpc-provider.test.jsandchain.test.jspass (69). Oracle tests: 1,546; CI runs the full suite.Deploy
Both operators.
🤖 Generated with Claude Code