fix(react): close thread view when its parent message is deleted - #1368
Open
ishan-one8 wants to merge 1 commit into
Open
fix(react): close thread view when its parent message is deleted#1368ishan-one8 wants to merge 1 commit into
ishan-one8 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the state leak described in #1080. When the parent message of an open thread was deleted,
messageStore.removeMessageremoved the message from the main list (and from thread replies) but never checked whether the deleted message was the thread'sthreadMainMessage. As a result the Thread View stayed open, showing a stale copy of a message that no longer exists.This updates
removeMessageso that when the deleted message is the currentthreadMainMessage, the thread state is reset (isThreadOpen: false,threadMainMessage: null,threadMessages: []) in the same update — mirroring whatcloseThreadalready does. SinceremoveMessageis wired to the message-delete listener, this works for deletions from EmbeddedChat as well as from other clients.Acceptance Criteria fulfillment
threadMainMessage?._id === messageIdcheck)PR Test Details
Fixes #1080