Skip to content

chore(s2s): drop kokoro-onnx from the all extra - #894

Merged
maciejmajek merged 1 commit into
mainfrom
chore/s2s-kokoro-opt-in
Nov 10, 2026
Merged

maciejmajek merged 1 commit into
mainfrom
chore/s2s-kokoro-opt-in

Conversation

@maciejmajek

Copy link
Copy Markdown
Member

kokoro-onnx depends on GPL-3.0 packages (phonemizer-fork, espeakng-loader). This removes it from rai_s2s[all] (and so from the s2s group and Docker --all-groups builds), keeping it available via rai_s2s[kokoro].

The kokoro_onnx import is now lazy so rai_s2s still imports without it. Docs note how to install KokoroTTS explicitly.

kokoro-onnx pulls in GPL-3.0 packages (phonemizer-fork, espeakng-loader).
Keep it opt-in via rai_s2s[kokoro] and import it lazily so rai_s2s
imports without it.
@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.32%. Comparing base (d0cf7b0) to head (ed8ddd4).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
+ Coverage   76.29%   76.32%   +0.02%     
==========================================
  Files          83       83              
  Lines        3670     3670              
==========================================
+ Hits         2800     2801       +1     
+ Misses        870      869       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@maciejmajek
maciejmajek merged commit 30ea963 into main Nov 10, 2026
10 checks passed
@maciejmajek
maciejmajek deleted the chore/s2s-kokoro-opt-in branch November 10, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants