Skip to content

test: raise ROS message and TF timeouts for slower runners - #888

Merged
maciejmajek merged 1 commit into
mainfrom
test/slow-runner-timeouts
Nov 6, 2026
Merged

maciejmajek merged 1 commit into
mainfrom
test/slow-runner-timeouts

Conversation

@maciejmajek

Copy link
Copy Markdown
Member

Purpose

  • Make ROS 2 tests pass reliably on GitHub-hosted runners (4 vCPU). Several tests time out there while waiting for the first message or transform.

Proposed Changes

  • test_topic_tools.py:
    • test_receive_message_tool, test_receive_image_tool, test_receive_message_tool_with_readable_topic: pass timeout_sec=5.0 (tool default is 1.0).
    • test_get_transform_tool: timeout_sec 1.0 to 5.0.
    • test_get_transform_tool_with_stale_tf_data_sim_time: first lookup timeout_sec 5.0 to 15.0. The test clock runs at 2x, so 5.0 was only 2.5 s of real time.
  • test_transport.py: receive_message timeout 5.0 to 15.0.
  • Timeouts only cap the wait. Passing runs are not slower.

Issues

Testing

  • CI on this PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.40%. Comparing base (38853fa) to head (eb3f392).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
+ Coverage   76.37%   76.40%   +0.02%     
==========================================
  Files          83       83              
  Lines        3670     3670              
==========================================
+ Hits         2803     2804       +1     
+ Misses        867      866       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@maciejmajek
maciejmajek merged commit 2bc2f32 into main Nov 6, 2026
10 checks passed
@maciejmajek
maciejmajek deleted the test/slow-runner-timeouts branch November 6, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants