Skip to content

Add rtabmap_rviz_plugins - #238

Open
robostack-bot-dev[bot] wants to merge 5 commits into
mainfrom
bot/add-package-44677568323
Open

robostack-bot-dev[bot] wants to merge 5 commits into
mainfrom
bot/add-package-44677568323

Conversation

@robostack-bot-dev

Copy link
Copy Markdown
Contributor
  • rolling: rtabmap_rviz_plugins is not in its rosdistro

  • humble: adding rtabmap_rviz_plugins → 0 new packages to build on linux-64

    • already published (built as a dependency): rtabmap_rviz_plugins
  • jazzy: adding rtabmap_rviz_plugins → 0 new packages to build on linux-64

    • already published (built as a dependency): rtabmap_rviz_plugins
  • lyrical: adding rtabmap_rviz_plugins → 0 new packages to build on linux-64

    • already published (built as a dependency): rtabmap_rviz_plugins

Added to shared/vinca.yaml (every distribution that has them builds them). CI builds the new packages on all platforms.

🤖 robostack-bot

Closes #237

@robostack-bot-dev robostack-bot-dev Bot added the robostack-bot robostack-bot commands and PRs label Nov 20, 2026
@github-actions github-actions Bot mentioned this pull request Nov 20, 2026
5 tasks done
Tobias-Fischer and others added 3 commits November 20, 2026 12:30
conda-forge's VTK links Qt 6 (VTK::GUISupportQt and VTK::RenderingQt), and
so does rtabmap's GUI. Both reach the plugin's link interface:
rtabmap_conversions::rtabmap_conversions exports rtabmap::gui
(Qt6::Widgets;Core;Gui;OpenGL) and rtabmap::core, whose interface lists
pcl_visualization and VTK::GUISupportQt (Qt6::OpenGL;Widgets;OpenGLWidgets);
pcl_conversions_LIBRARIES carries the same PCL/VTK list. With jazzy's and
humble's Qt 5 RViz, CMake then fails with "INTERFACE_QT_MAJOR_VERSION of
Qt6::OpenGL does not agree with QT_MAJOR_VERSION".

The plugin uses none of them (only rtabmap/core and pcl_conversions
headers), so when it is built with Qt 5 the patch drops the Qt 6 targets,
VTK's Qt modules, rtabmap::gui and pcl_visualization from the imported
targets' link interfaces and from the pcl_conversions-style _LIBRARIES
variables. Distributions with a Qt 6 RViz (lyrical) don't find Qt5, and the
block does nothing there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The previous commit keeps VTK's and rtabmap's Qt 6 out of the Qt 5 plugin,
so the exclusions go. humble keeps rtabmap without Qt and rtabmap_viz
excluded.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Tobias-Fischer Tobias-Fischer added build:jazzy PR build: build only jazzy (with other build:<distro> labels: only those) build:humble PR build: build only humble (with other build:<distro> labels: only those) labels Nov 20, 2026
rtabmap was built with -DWITH_QT=OFF on humble (from the old ros-humble repo),
so it had no GUI library and rtabmap_viz was excluded. Build it as jazzy does:
with VTK's Qt 6, which adds librtabmap_gui (build number 26 to rebuild it).
rtabmap_viz is a Qt 6 application of its own; rtabmap_rviz_plugins (Qt 5, like
humble's RViz) keeps rtabmap's GUI out with the previous commit's patch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

ABI check (linux-64)

humble linux-64: 1 to review (changed headers)
package released → PR verdict details
rtabmap 0.23.14 (build 25) → 0.23.14 compatible: no ABI change 41 headers changed (check for layout/inline changes): +rtabmap-0.23/rtabmap/gui/AboutDialog.h, +rtabmap-0.23/rtabmap/gui/CalibrationDialog.h, +rtabmap-0.23/rtabmap/gui/CameraViewer.h, +rtabmap-0.23/rtabmap/gui/CloudViewer.h, +rtabmap-0.23/rtabmap/gui/CloudViewerCellPicker.h, +rtabmap-0.23/rtabmap/gui/CloudViewerInteractorStyle.h, +rtabmap-0.23/rtabmap/gui/ConsoleWidget.h, +rtabmap-0.23/rtabmap/gui/CreateSimpleCalibrationDialog.h and 33 more

Compared with the newest builds on https://conda.anaconda.org/robostack-humble/linux-64.

About this check

Each package this pull request built, compared with its newest released build (tools/abi_check.py, libabigail):

  • compatible / additions: the package can be bumped on its own;
  • soname / incompatible: the packages that depend on it need a rebuild (build number bump) in the same pull request.

Exported symbols are compared (the released packages are stripped, so struct layouts aren't); unchanged installed headers rule out layout and inline changes, changed ones are listed for review. Dependents to rebuild are the released ones linking to a changed library. A changed pin is part of the comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build:humble PR build: build only humble (with other build:<distro> labels: only those) build:jazzy PR build: build only jazzy (with other build:<distro> labels: only those) robostack-bot robostack-bot commands and PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package request: rtabmap_rviz_plugins

2 participants