Repository navigation
Add rtabmap_rviz_plugins - #238
Open
robostack-bot-dev[bot] wants to merge 5 commits into
Open
robostack-bot-dev[bot] wants to merge 5 commits into
robostack-bot-dev[bot] wants to merge 5 commits into
Conversation
5 tasks done
conda-forge's VTK links Qt 6 (VTK::GUISupportQt and VTK::RenderingQt), and so does rtabmap's GUI. Both reach the plugin's link interface: rtabmap_conversions::rtabmap_conversions exports rtabmap::gui (Qt6::Widgets;Core;Gui;OpenGL) and rtabmap::core, whose interface lists pcl_visualization and VTK::GUISupportQt (Qt6::OpenGL;Widgets;OpenGLWidgets); pcl_conversions_LIBRARIES carries the same PCL/VTK list. With jazzy's and humble's Qt 5 RViz, CMake then fails with "INTERFACE_QT_MAJOR_VERSION of Qt6::OpenGL does not agree with QT_MAJOR_VERSION". The plugin uses none of them (only rtabmap/core and pcl_conversions headers), so when it is built with Qt 5 the patch drops the Qt 6 targets, VTK's Qt modules, rtabmap::gui and pcl_visualization from the imported targets' link interfaces and from the pcl_conversions-style _LIBRARIES variables. Distributions with a Qt 6 RViz (lyrical) don't find Qt5, and the block does nothing there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The previous commit keeps VTK's and rtabmap's Qt 6 out of the Qt 5 plugin, so the exclusions go. humble keeps rtabmap without Qt and rtabmap_viz excluded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # distros/jazzy/vinca.yaml
rtabmap was built with -DWITH_QT=OFF on humble (from the old ros-humble repo), so it had no GUI library and rtabmap_viz was excluded. Build it as jazzy does: with VTK's Qt 6, which adds librtabmap_gui (build number 26 to rebuild it). rtabmap_viz is a Qt 6 application of its own; rtabmap_rviz_plugins (Qt 5, like humble's RViz) keeps rtabmap's GUI out with the previous commit's patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ABI check (linux-64)humble linux-64: 1 to review (changed headers)
Compared with the newest builds on https://conda.anaconda.org/robostack-humble/linux-64. About this checkEach package this pull request built, compared with its newest released build (
Exported symbols are compared (the released packages are stripped, so struct layouts aren't); unchanged installed headers rule out layout and inline changes, changed ones are listed for review. Dependents to rebuild are the released ones linking to a changed library. A changed pin is part of the comparison. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rolling:
rtabmap_rviz_pluginsis not in its rosdistrohumble: adding
rtabmap_rviz_plugins→ 0 new packages to build on linux-64rtabmap_rviz_pluginsjazzy: adding
rtabmap_rviz_plugins→ 0 new packages to build on linux-64rtabmap_rviz_pluginslyrical: adding
rtabmap_rviz_plugins→ 0 new packages to build on linux-64rtabmap_rviz_pluginsAdded to
shared/vinca.yaml(every distribution that has them builds them). CI builds the new packages on all platforms.🤖 robostack-bot
Closes #237