Repository navigation
[NVBUG 7115760] Rebuild Lyrical against Zenoh 1.10.2 - #236
Closed
aayoung-nv wants to merge 1 commit into
Closed
aayoung-nv wants to merge 1 commit into
aayoung-nv wants to merge 1 commit into
Conversation
Signed-off-by: aayoung <aayoung@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft: native package build and runtime validation remain outstanding.
Build Lyrical against conda-forge
libzenohcandlibzenohcxx1.10.2 instead of 1.10.1. Keep the change indistros/lyrical/; other distributions retain their current pins.Zenoh 1.10.2 includes the StartConditions deadlock correction in eclipse-zenoh/zenoh#2779, which closes eclipse-zenoh/zenoh#2581. The conda-forge 1.10.1 package source lacks that correction. Related upstream ROS work: ros2/rmw_zenoh#1069.
Lyrical's vendor uses
USE_SYSTEM_ZENOH=ON. This updates the system library pins; it deliberately leaves the ROS release snapshot unchanged. Whether these rebuilt packages resolve the observed Windows composed-Nav2 discovery/RPC stall still needs a native A/B test without queue overrides.Rebuild scope
The repository's
vinca-rebuild-planreports 735 affected packages out of 1,253 selected packages. Direct users arezenoh_cpp_vendorandrmw_zenoh_cpp. Because this exceeds the 50% threshold, use the repository's conservative full-rebuild policy:full_rebuild: true.This scope follows the dependency planner, not a measured ABI break in every dependent. An ABI-backed smaller rebuild would need separate validation. Reset the temporary PR cache controls after merging, per repository guidance.
conda_build_config.yamlwas regenerated withpixi run rs lyrical render-pinning, not edited by hand.Local validation
pixi run rs check.pixi run test: 83 passed.git diff --check.libzenohc ==1.10.2pluslibzenohcxx ==1.10.2onwin-64andlinux-64with Lyrical's generated variant configuration.libopencv,pcl,py-opencv, andqt-mainconflicts, plus the samelibcameranote. This is not a full dependency-check pass.No full native rebuild was started locally. Dependency solves are not binary or runtime validation.