Skip to content

One bash build script per build type, run with brush on Windows - #225

Draft
Tobias-Fischer wants to merge 1 commit into
vinca-rs/4-package-filesfrom
vinca-rs/test-brush
Draft

Tobias-Fischer wants to merge 1 commit into
vinca-rs/4-package-filesfrom
vinca-rs/test-brush

Conversation

@Tobias-Fischer

@Tobias-Fischer Tobias-Fischer commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

vinca-rs with prefix-dev/pixi#7540's build scripts:

  • ament_cmake and cmake share one template: conda's ${CMAKE_ARGS}, BUILD_TESTING=OFF, and a PYTHON_INSTALL_DIR relative to the prefix for both.
  • The ROS 2 build scripts are bash scripts on every platform; Windows runs them with brush.
  • rtabmap's Windows link flags are in bash syntax ($LIBRARY_LIB instead of %LIBRARY_LIB%).

Tested: run 43573597330 rebuilt ros_workspace, ament_cmake_test, rcutils, builtin_interfaces, fastcdr, ruckig, ament_index_python and demo_nodes_py on all five platforms, together with about 25 other humble recipes. Locally on osx-arm64, the packages built with the old and the new scripts, and under bash and brush, contain the same files and have the same run dependencies.

Draft until vinca-rs 0.1.10 is released (Tobias-Fischer/vinca-rs#9); until then vinca-rs is a pixi source dependency on its branch, which CI compiles in every job.

🤖 Generated with Claude Code

@Tobias-Fischer Tobias-Fischer added the build:humble PR build: build only humble (with other build:<distro> labels: only those) label Nov 14, 2026
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

ABI check (linux-64)

About this check

Each package this pull request built, compared with its newest released build (tools/abi_check.py, libabigail):

  • compatible / additions: the package can be bumped on its own;
  • soname / incompatible: the packages that depend on it need a rebuild (build number bump) in the same pull request.

Exported symbols are compared (the released packages are stripped, so struct layouts aren't); unchanged installed headers rule out layout and inline changes, changed ones are listed for review. Dependents to rebuild are the released ones linking to a changed library. A changed pin is part of the comparison.

@Tobias-Fischer Tobias-Fischer removed the build:humble PR build: build only humble (with other build:<distro> labels: only those) label Nov 14, 2026
@Tobias-Fischer Tobias-Fischer changed the title TEMPORARY test: one bash build script per build type, with brush on Windows One bash build script per build type, run with brush on Windows Nov 14, 2026
@Tobias-Fischer Tobias-Fischer added the build:none PR build: build no packages, only run the checks (tooling, CI or docs changes) label Nov 14, 2026
@Tobias-Fischer
Tobias-Fischer force-pushed the vinca-rs/test-brush branch 2 times, most recently from 49e7780 to beed05d Compare November 14, 2026 12:17
@Tobias-Fischer
Tobias-Fischer removed this pull request from stack #226 November 21, 2026 10:12
vinca-rs with prefix-dev/pixi#7540's build scripts: ament_cmake and cmake share
one template (with conda's ${CMAKE_ARGS}, BUILD_TESTING=OFF and a
PYTHON_INSTALL_DIR relative to the prefix for both), and the ROS 2 scripts are
bash scripts on every platform, run with brush on Windows. rtabmap's Windows link
flags are in bash syntax ($LIBRARY_LIB).

vinca-rs comes from its branch (a pixi source dependency) until 0.1.10 is released.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build:none PR build: build no packages, only run the checks (tooling, CI or docs changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant