Add clean and highlighted-subtitle video export - #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.asarlayoutsnanoidlock entry to 3.3.18 after CI identified GHSA-2v37-7h3g-55p8Validation
npm.cmd audit --audit-level=high: passed, zero vulnerabilitiesnpm.cmd test: passed, 55 tests across 11 filesnpm.cmd run typecheck: passednpm.cmd run build: passednpm.cmd run build:desktop: passed (client and bundled local server)POST /api/recordings/subtitles: returned a valid MP4 that decoded cleanly; inspected frame confirmed Georgia rendering, lower-third placement, full-line display, and active-word highlightinggit diff --cached --check: passed before commitvalidate: passedNotes
npm.cmd run speech:smokeandnpm.cmd run speech:smoke:arm64cannot start on this Windows ARM64 development host because their unchanged bootstrap requires asherpa-onnx-win-arm64native addon that the project does not install. The failure occurs before this change's code loads; the feature's speech-timing logic is covered by focused unit tests.