Repository navigation
fix: reject invalid saved policy without resetting defaults - #705
guangyu-reflexio wants to merge 5 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reached
This review includes 15 billable files and costs up to $3.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 19 minutes for your next included review. View limit details
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6963097b7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
An invalid recognized saved setting can currently be caught by a config loader and replaced by defaults, losing unrelated retention holds or storage routing. Reject the invalid saved policy through one shared error family, including validation during legacy conversion. This retires zero configuration knobs. It is a prerequisite for safely restoring/redesigning previously fixed housekeeping settings.
Changes
Dependencies
Stacked on #704 (which depends on #703). Incremental diff: team/config-discovery-timing-correction...team/config-stored-policy-validation. Merge parents first.
Test Plan
Codex P1 diagnostic-key collision fixed: reporting only authoritative top-level settings excludes nested map identifiers even when they match declared properties (
enabled,model,db_url,similarity_threshold). Reinstating the initial formatter fails all five privacy regressions; corrected source restored. Latest-head review/CI qualification is pending.