Skip to content

todo-angular app update - #28

Open
MariaF-Ordonez wants to merge 1 commit into
masterfrom
mordonez/update-todo-angular
Open

todo-angular app update#28
MariaF-Ordonez wants to merge 1 commit into
masterfrom
mordonez/update-todo-angular

Conversation

@MariaF-Ordonez

Copy link
Copy Markdown

The minor update includes the change of the "Stuff to do" text from the list.html file to "Task list"

@herve4m herve4m left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe you also want to edit the Dockerfile (updatedDate and an up-to-date base image (FROM registry.access.redhat.com/ubi10:10.2))

@@ -1,5 +1,5 @@
<div class="page-header">
<h1>Stuff to do...</h1>
<h1>Task list</h1>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's a title, maybe:

Suggested change
<h1>Task list</h1>
<h1>Task List</h1>

But you can keep it as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants