Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds first-class Windows desktop support to the Tauri app and fixes a console-window flashing issue that only shows up when running the desktop app on Windows.
Changes
1. Windows desktop window behavior
crates/hk-desktop/tauri.windows.conf.jsonso Windows builds don't inherit the macOS-only window styling (transparent: true, sidebar vibrancy, overlay title bar). On Windows this previously rendered a transparent window that visually overlapped other apps and flickered while dragging.main.rs: macOS keeps hide-on-close (dock), Windows/Linux quit on close instead of leaving a hidden background process.2. No more console window flashes
hk_core::command()(crates/hk-core/src/process.rs) which setsCREATE_NO_WINDOWon Windows.where/ npm probing inscanner,manager,service,skills_cli, and the desktopextensions/installcommands). Previously each probe of a CLI binary (where wecom-cli, …) flashed a console window when launched from the GUI process.Testing
cargo tauri build --no-bundle) and verified the window renders with a standard title bar and no transparent overlap.where.exeprobes spawned during scanning no longer createconhost.execonsole windows.