fix: restore CASW_Inhabitable_NPC client class registration - #1087
Merged
Kitsune44 merged 1 commit intoAug 12, 2026
Merged
Conversation
The #define CASW_Inhabitable_NPC C_ASW_Inhabitable_NPC from rd_inventory_shared.h was leaking into c_asw_inhabitable_npc.cpp via c_asw_player.h, causing the IMPLEMENT_CLIENTCLASS_DT invocation to expand incorrectly (third argument stringified as "C_ASW_Inhabitable_NPC" instead of "CASW_Inhabitable_NPC"). This caused the "Client missing DT class CASW_Inhabitable_NPC" error and a crash when parsing entity updates on maps with such entities (e.g. rd-par2hostile_places). This matches the existing pattern in c_asw_player.cpp and c_asw_marine_resource.cpp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #define CASW_Inhabitable_NPC C_ASW_Inhabitable_NPC from rd_inventory_shared.h was leaking into c_asw_inhabitable_npc.cpp via c_asw_player.h, causing the IMPLEMENT_CLIENTCLASS_DT invocation to expand incorrectly (third argument stringified as "C_ASW_Inhabitable_NPC" instead of "CASW_Inhabitable_NPC").
This caused the "Client missing DT class CASW_Inhabitable_NPC" error and a crash when parsing entity updates on maps with such entities (e.g. rd-par2hostile_places).
This matches the existing pattern in c_asw_player.cpp and c_asw_marine_resource.cpp.