fix(cli): validate q server port arguments - #11
Merged
protocolstardust merged 1 commit intoSep 25, 2026
Merged
Conversation
Collaborator
|
Reviewed and merged (4322f53). What was checked
One consequence to be aware of: the Makefile patch now depends on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for users
rayforce -qandrayforce --q-servenow fail clearly and consistently when the port is missing or invalid. The process prints a direct diagnostic and exits with status2, instead of reporting a misleading file-open/unknown-option error or continuing with exit status0. Arguments after--remain application arguments and are not interpreted as Q-server flags.What changed
rayforcebinary.Validation
make testwith local fresh Rayforce core: passed (codec, exchange, server round-trip, malformed-frame, real-q interop, client, auth, and push suites).-q 70000-> exit 2;-q-> exit 2;--q-serve-> exit 2;-- -q 70000-> exit 0.-Werror: passed.origin/master(1eabaf4).