Skip to content

Gapless editor fixes - #1693

Merged
zetter-rpf merged 2 commits into
mainfrom
gapless-editor-improvements
Oct 16, 2026
Merged

zetter-rpf merged 2 commits into
mainfrom
gapless-editor-improvements

Conversation

@zetter-rpf

Copy link
Copy Markdown
Contributor

Related to #1685

This fixes a couple of display issues (see commits for more)

Screenshot 2026-10-16 at 13 21 17 Screenshot 2026-10-16 at 14 58 37

As the border radius properties that are based on writing mode are newer, we use a polyfill which applies them based on language.

This interfered with resetting the border to 0 as the radii created by the polyfill had higher specificity.

Reset them using the same attributes so they are also polyfilled, and have enough specificity to override.
@zetter-rpf
zetter-rpf marked this pull request as ready for review October 16, 2026 13:59
@zetter-rpf zetter-rpf changed the title Gapless editor improvements Gapless editor fixes Oct 16, 2026
Comment thread src/assets/stylesheets/Sidebar.scss Outdated
@maxelkins

Copy link
Copy Markdown
Contributor

Nice, 1 minor comment 👍

After the change to remove gaps from the side, the sidebar should only have a border-radius on the top-right side. Also convert to use more consistent units.
@zetter-rpf
zetter-rpf force-pushed the gapless-editor-improvements branch from 9e09a68 to 2d10231 Compare October 16, 2026 14:19
@zetter-rpf
zetter-rpf merged commit 1dcce22 into main Oct 16, 2026
12 checks passed
@zetter-rpf
zetter-rpf deleted the gapless-editor-improvements branch October 16, 2026 14:53

This branch was successfully deployed

1 active deployment
previews/1693/merge — 2d10231e Deployed Oct 16, 2026 by zetter-rpf via deploy-branch / build-deploy #6926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants