docs: remove unused LanguageFilter imports from starting page - #812
Merged
Conversation
Co-Authored-By: lino <68745352+LinoGiger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Audio and Text tabs of the docs landing page import
LanguageFilterbut never use it — leftovers from when these examples used the deprecated order API, which took afilters=argument.create_compare_job_definitionhas nofiltersparameter; in the Jobs model, annotator filtering lives on the audience (audience.filter([LanguageFilter(["en"])]), documented indocs/audiences.md). The dangling import points readers at a parameter that does not exist on the job path.This came out of investigating why a customer on the latest SDK (3.19.2) reached for
create_compare_orderinstead of a job definition: they needed an English-only audience, andfilters=only exists on the deprecated order API. The unused import here is one of the trails leading there.Docs-only, two lines. Verified with
uv run --group docs mkdocs build— builds clean, remaining warnings are pre-existing and unrelated.🔗 Session: session-af1a7b32