Skip to content

Fix Eikthyr shard rarity scaling - #744

Open
jneb802 wants to merge 2 commits into
RandyKnapp:mainfrom
jneb802:fix/eikthyr-shard-rarity-scaling
Open

jneb802 wants to merge 2 commits into
RandyKnapp:mainfrom
jneb802:fix/eikthyr-shard-rarity-scaling

Conversation

@jneb802

@jneb802 jneb802 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Problem

Eikthyr Shocking Charge stores a different value for each shard rarity, but the runtime damage calculation does not use that value. Every rarity therefore releases 30% of banked damage after 15 hits.

Changes

  • Scale the released damage from the configured shard value.
  • Preserve Epic at the existing 30% baseline.
  • Use 20%, 30%, 40%, 50%, and 60% for Rare through Ancient with the default values.
  • Show the damage percentage and required hit count in the tooltip.
  • Add a configurable reference value for custom server rarity ramps.

Validation

  • Reproduced the fault by tracing the configured rarity values through the equipped-effect lookup into the discharge calculation.
  • Built EpicLoot on macOS against the local Valheim assemblies.
  • Build result: 0 errors.

The build reports existing environment warnings for the Windows-style Managed folder check and missing mod-tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant